[FOLLOWUP] Clarify Variant specification details #457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@julienledem Here is a followup PR to address some of your comments/questions from the previous PR. Could you please take a look? Thanks! |
wgtmac
reviewed
Oct 17, 2024
wgtmac
approved these changes
Oct 18, 2024
Contributor
Author
|
@julienledem Could you please take a look at these followup changes? Thanks! |
Fokko
reviewed
Oct 31, 2024
Fokko
approved these changes
Oct 31, 2024
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Add more clarification and justification for various aspects of the Variant specification.
What changes are included in this PR?
Details and clarification to the Variant spec. Addressing some feedback from previous PR: #456