Skip to content

Make cache expiration time configurable #5076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tysonnorris merged 1 commit into from
Mar 10, 2021
Merged

Make cache expiration time configurable #5076

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .../src/main/scala/org/apache/openwhisk/core/database/MultipleReadersSingleWriterCache.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,8 @@ trait MultipleReadersSingleWriterCache[W, Winfo] {
/** Subclasses: Toggle this to enable/disable caching for your entity type. */
protected val cacheEnabled = true
protected val evictionPolicy: EvictionPolicy = AccessTime
protected val cacheExpirationTime: Long = 5
protected val cacheExpirationTimeUnit: TimeUnit = TimeUnit.MINUTES
protected val fixedCacheSize = 0

private object Entry {
Expand Down Expand Up @@ -452,8 +454,8 @@ trait MultipleReadersSingleWriterCache[W, Winfo] {
.softValues()

evictionPolicy match {
case AccessTime => b.expireAfterAccess(5, TimeUnit.MINUTES)
case _ => b.expireAfterWrite(5, TimeUnit.MINUTES)
case AccessTime => b.expireAfterAccess(cacheExpirationTime, cacheExpirationTimeUnit)
case _ => b.expireAfterWrite(cacheExpirationTime, cacheExpirationTimeUnit)
}

if (fixedCacheSize > 0) b.maximumSize(fixedCacheSize)
Expand Down