Skip to content

Remove runtime builds #3745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
csantanapr merged 1 commit into from
Jun 21, 2018
Merged

Remove runtime builds #3745

csantanapr merged 1 commit into from
Jun 21, 2018

Conversation

@rabbah
Copy link
Member

@rabbah rabbah commented Jun 11, 2018

Description

This PR extends #3680 and removes the gradle tasks which build of the action runtimes. The images are expected to be build by their respective repositories and published to a common registry. It is still possible to develop a runtime locally and test without publishing the image by the image pulls.

# skip image pulls
    ansible-playbook -i environments/local invoker.yml -e 'skip_pull_runtimes=true'

# similarly using redo aka wskdev
    redo invoker -e"skip_pull_runtimes=true"

The redo utility was update to build generic runtimes by specifying their name to a runtime:<name> task where name is matches a wide regex. The repository is expected to follow the standard gradle build process.

   redo --dir /path/to/runtime/repo runtime:nodejs6action

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

@rabbah rabbah force-pushed the remove-runtime-builds branch from e0e6f1c to b3bcb87 Compare June 11, 2018 03:38
@rabbah rabbah requested a review from csantanapr June 11, 2018 03:38
@rabbah rabbah added the review Review for this PR has been requested and yet needs to be done. label Jun 11, 2018
This was referenced Jun 11, 2018
Closed
Merged
@rabbah
Copy link
Member Author

rabbah commented Jun 11, 2018

@chetanmeh this should knock this down further re #3467 (comment).

@codecov-io
Copy link

codecov-io commented Jun 11, 2018 •
edited
Loading

Codecov Report

Merging #3745 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3745      +/-   ##
==========================================
- Coverage   74.92%   74.92%   -0.01%     
==========================================
  Files         132      132              
  Lines        6182     6181       -1     
  Branches      384      385       +1     
==========================================
- Hits         4632     4631       -1     
  Misses       1550     1550
Impacted Files Coverage Δ
...ain/scala/whisk/core/entitlement/Entitlement.scala 76.42% <0%> (-0.2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09d9a91...4031526. Read the comment docs.

@rabbah
Copy link
Member Author

rabbah commented Jun 11, 2018 •
edited
Loading

or maybe not as much... since the images are pulled, and while they are largely static, we aren't benefiting from docker caching.

Ran for 35 min 47 sec Total time 1 hr 12 min 1 sec (this pr)
vs
Ran for 48 min 12 sec Total time 1 hr 46 min 36 sec (pr 3467)

screen shot 2018-06-11 at 2 16 26 am

@rabbah rabbah force-pushed the remove-runtime-builds branch 2 times, most recently from 9516024 to 5ac10d5 Compare June 18, 2018 19:10
@rabbah
Copy link
Member Author

rabbah commented Jun 18, 2018

This is now rebased to pick up #3680.

@csantanapr csantanapr force-pushed the remove-runtime-builds branch from c8bb0fe to c0150b1 Compare June 20, 2018 01:56
rabbah
rabbah commented Jun 20, 2018
View reviewed changes
actionRuntimes/actionProxy/build.gradle
* limitations under the License.
*/

ext.dockerImageName = 'dockerskeleton'
Copy link
Member Author

@rabbah rabbah Jun 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we keep this just call this image something else?

Copy link
Member

@csantanapr csantanapr Jun 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actionproxy

Copy link
Member Author

@rabbah rabbah Jun 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok.

tools/build/redo

# the following (re)build images via gradle

makeComponent('actionproxy',
Copy link
Member Author

@rabbah rabbah Jun 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd also keep this - as a convenience for building a runtime quickly and testing it all from this repo.

csantanapr
csantanapr approved these changes Jun 20, 2018
View reviewed changes
Copy link
Member

@csantanapr csantanapr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csantanapr
Copy link
Member

csantanapr commented Jun 20, 2018

PG1 3043 🔵

@rabbah
Copy link
Member Author

rabbah commented Jun 20, 2018

@csantanapr when you merge this you should get co-author credit.

@rabbah
Copy link
Member Author

rabbah commented Jun 20, 2018

By the way can we restore the two files I commented on?

@rabbah @csantanapr
Remove builds of the runtimes which only retagged images locally.
4031526 
Co-authored-by: Rodric Rabbah <rodric@gmail.com>
Co-authored-by: Carlos Santana <csantanapr@apache.org>
@csantanapr csantanapr force-pushed the remove-runtime-builds branch from c0150b1 to 4031526 Compare June 21, 2018 00:43
@csantanapr
Copy link
Member

csantanapr commented Jun 21, 2018

By the way can we restore the two files I commented on?

@rabbah files are restored you get back wskdev actionproxy

@csantanapr csantanapr merged commit 2254e4f into apache:master Jun 21, 2018
@rabbah rabbah deleted the remove-runtime-builds branch June 21, 2018 12:28
@csantanapr csantanapr mentioned this pull request Jun 21, 2018
Merged
BillZong pushed a commit to BillZong/openwhisk that referenced this pull request Nov 18, 2019
@rabbah @csantanapr
Remove builds of the runtimes which only retagged images locally. (ap…
ea0be3d 
…ache#3745)

Co-authored-by: Rodric Rabbah <rodric@gmail.com>
Co-authored-by: Carlos Santana <csantanapr@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@csantanapr csantanapr csantanapr approved these changes

Assignees

@csantanapr csantanapr

Labels

deployment review Review for this PR has been requested and yet needs to be done.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rabbah @codecov-io @csantanapr