missing null check during TestUtils initialization

[rabbah]

in this method https://github.com/apache/incubator-openwhisk/blob/37ce9b86048dafb0f369a5a5b05caa0136a26ef4/tests/src/test/scala/common/WhiskProperties.java#L297 there's a missing null check:

public static File getVCAPServicesFile() {
        String vcapServices = whiskProperties.getProperty("vcap.services.file");
        if (vcapServices.startsWith(File.separator)) {
            return new File(vcapServices);
        } else {
            return WhiskProperties.getFileRelativeToWhiskHome(vcapServices);
        }
    }

@jasonpet the vcap property does not appear to be used anymore in this repo:

https://github.com/apache/incubator-openwhisk/blob/9e5cec1f0e4b98c59e584d453b06a741be4a8c3b/tests/src/test/scala/common/TestUtils.java#L79

(per git blame f9b4f48) is this used in the providers only now - if so i'm wondering if we can move it this code out.

[jasonpet]

in this method https://github.com/apache/incubator-openwhisk/blob/37ce9b86048dafb0f369a5a5b05caa0136a26ef4/tests/src/test/scala/common/WhiskProperties.java#L297 there's a missing null check:

public static File getVCAPServicesFile() {
        String vcapServices = whiskProperties.getProperty("vcap.services.file");
        if (vcapServices.startsWith(File.separator)) {
            return new File(vcapServices);
        } else {
            return WhiskProperties.getFileRelativeToWhiskHome(vcapServices);
        }
    }

@jasonpet the vcap property does not appear to be used anymore in this repo:

https://github.com/apache/incubator-openwhisk/blob/9e5cec1f0e4b98c59e584d453b06a741be4a8c3b/tests/src/test/scala/common/TestUtils.java#L79

(per git blame f9b4f48) is this used in the providers only now - if so i'm wondering if we can move it this code out.

providers do not use getVCAPServicesFile(), but do use getVCAPcredentials()

[jasonpet]

not sure if any other openwhisk repos use vcap outside of providers. maybe catalog or runtimes?

[dgrove-oss]

fwiw, I have pretty much all the repos cloned locally. Here's what I see with some recursive finds. Fairly limited downstream usage.

daves-mbp:openwhisk dgrove$ qfind getVCAPServices
./openwhisk/tests/src/test/scala/common/WhiskProperties.java
./openwhisk-devtools/docker-compose/openwhisk-src/tests/src/test/scala/common/TestUtils.java
./openwhisk-devtools/docker-compose/openwhisk-src/tests/src/test/scala/common/WhiskProperties.java
daves-mbp:openwhisk dgrove$ qfind getVCAPcredentials
./openwhisk-package-cloudant/tests/src/test/scala/system/CloudantUtil.java
./openwhisk-catalog/tests/src/test/scala/packages/weather/WeatherTests.scala
./ibm-functions-runtime-nodejs/tests/src/test/scala/runtime/integration/CredentialsIBMNodeJsDb2CloudTests.scala
./ibm-functions-runtime-nodejs/tests/src/test/scala/runtime/integration/CredentialsIBMNodeJsActionCloudantTests.scala
./ibm-functions-runtime-nodejs/tests/src/test/scala/runtime/integration/CredentialsIBMNodeJsActionWatsonTests.scala
./openwhisk-devtools/docker-compose/openwhisk-src/tests/src/test/scala/common/TestUtils.java
./ibm-functions-runtime-python/tests/build/tmp/scala/compilerAnalysis/compileTestScala.analysis
./ibm-functions-runtime-python/tests/src/test/scala/integration/CredentialsIBMPythonDb2CloudTests.scala
./ibm-functions-runtime-python/tests/src/test/scala/integration/CredentialsIBMPythonWatsonTests.scala
./ibm-functions-runtime-python/tests/src/test/scala/integration/CredentialsIBMPythonCloudantTests.scala
./ibm-functions-runtime-swift/tests/build/tmp/scala/compilerAnalysis/compileTestScala.analysis
./ibm-functions-runtime-swift/tests/src/test/scala/runtime/integration/CredentialsIBMSwiftActionWatsonTests.scala
```

[rabbah]

Downstream Apache repos mix getCredentials and getVCAPcredentials. I did not check IBM or other external repos, obviously.

My plan was to move the parameter reading into the downstream repos that needed it. Given the wider use, I'm inclined to leave it as is until after 1.0.

https://github.com/apache/openwhisk-catalog/search?q=getCredentials&unscoped_q=getCredentials
https://github.com/apache/openwhisk-catalog/search?q=getVCAPcredentials&unscoped_q=getVCAPcredentials
https://github.com/apache/openwhisk-package-pushnotifications/search?q=getVCAPcredentials&unscoped_q=getVCAPcredentials
https://github.com/apache/openwhisk-package-cloudant/search?q=getVCAPcredentials&unscoped_q=getVCAPcredentials
https://github.com/apache/openwhisk-package-kafka/search?q=getCredentials&unscoped_q=getCredentials