Add PHP 7.2.6 runtime #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
This runtime uses an updated router.php which runs the action code in the same process and enables PHP's OPcache byte-code cache. We also read the /init config information using `require` rather than parsing a JSON file. This results in a significant performance improvement as can be seen in the typical gatlingRun-LatencySimulation results on my dev machine. The mean response times are: * Warm php:7.1 invocation : 70ms * Warm nodejs:8 invocation : 19ms * Warm php:7.2 invocation : 19ms
csantanapr
reviewed
Jun 8, 2018
Member
csantanapr
left a comment
csantanapr
left a comment
There was a problem hiding this comment.
I think the php.ini long and not require.
Other than that LGTM
| @@ -0,0 +1,1948 @@ | |||
| ; Licensed to the Apache Software Foundation (ASF) under one or more | |||
Member
There was a problem hiding this comment.
this file looks too big and boiler plate.
Can we have a short version with a few settings that we need to override
csantanapr
requested changes
Jun 8, 2018
Member
csantanapr
left a comment
csantanapr
left a comment
There was a problem hiding this comment.
missing tests
Rename Php71ActionContainerTests.scala to Php7ActionContainerTests.scala and make it abstract class
Then
Create Php71ActionContainerTests.scala class with junit annotation and with override of the image name pointing to 7.1
Create Php72ActionContainerTests.scala same here but pointing to 7.2 docker image
Member
|
The new test file should look like this if there it's the same set of tests as 7.1 package runtime.actionContainers
import org.junit.runner.RunWith
import org.scalatest.junit.JUnitRunner
@RunWith(classOf[JUnitRunner])
class Php72ActionContainerTests extends Php7ActionContainerTests {
override lazy val nodejsContainerImageName = "action-php-v7.2"
} |
Member
Author
|
@csantanapr Tests added now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This runtime uses an updated router.php which runs the action code in
the same process and enables PHP's OPcache byte-code cache. We also
read the /init config information using
requirerather than parsing aJSON file.
This results in a significant performance improvement as can be seen
in the typical gatlingRun-LatencySimulation results on my dev machine.
The mean response times are:
The change to router.php can also be applied to the PHP 7.1 action and it will see similar performance improvements.