Skip to content

Conversation

@dubee
Copy link
Member

@dubee dubee commented Mar 6, 2019

Actions that depend on the Node.js client will require an annotation to allow such actions to access the API key associated with the corresponding namespace. These changes will be introduced by apache/openwhisk#4284. Since there exists tests in this repo that utilize the Node.js client, those tests will need to create actions with the mentioned annotation.

@dubee dubee requested a review from jasonpet March 6, 2019 03:35
@dubee dubee added the review label Mar 6, 2019
@dubee dubee changed the title Add API key annotations to tests that rely on Node.js client Add API key annotation to tests that rely on Node.js client Mar 6, 2019
Copy link

@jasonpet jasonpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dubee dubee merged commit 5ff7c6d into apache:master Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants