Add timeout configuration #653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- actorSystem terminate timeout - runtime pods delete timeout configuration
21 tasks
jiangpengcheng
approved these changes
Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #652
In kubenetes env, if runtime pod number is big and
akka.coordinated-shutdown.phases.actor-system-terminate_timeoutis low(e.g default value is30 s), this may lead tothe runtime pods are not deleted completely after execute helm delete/uninstall xxx, because when timeout happens, thecleanupis not executed finished.In such a case, need to increase relative timeout value, it is better to make these timeout value configurable.
Another brother pr: apache/openwhisk#5028