drivers/timers: A small improvements in the drivers/timers subsystem #17531
+2
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Area: Drivers
fangpeina
changed the title
acassis
previously requested changes
Dec 17, 2025
jerpelea
previously approved these changes
Dec 18, 2025
jerpelea
changed the title
xiaoxiang781216
previously approved these changes
Dec 20, 2025
The reference count (upper->crefs) is incremented in timer_open() only after ensuring it will not overflow, timer_close() is only called after a successful open. Therefore, crefs should never be zero when timer_close() is called. The check for crefs > 0 before decrementing is unnecessary and has been removed to simplify the code. Signed-off-by: fangpeina <fangpeina@xiaomi.com>
use DEBUGASSERT to check abnormal values in drivers/timers.c Signed-off-by: fangpeina <fangpeina@xiaomi.com>
fangpeina
dismissed stale reviews from xiaoxiang781216 and jerpelea
via
deac93a
xiaoxiang781216
approved these changes
Jan 7, 2026
Donny9
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A small improvements in the drivers/timers subsystem(including timer and watchdog drivers).
The changes focus on removing redundant or unreachable error-handling logic and improving
robustness checks using assertions, without altering the functional behavior of the drivers.
Impact
Users / Applications: No functional or behavioral changes.
Drivers: Affects drivers/timers/timer.c and drivers/timers/watchdog.c only.
Compatibility: No API or ABI changes.
Performance: No impact.
Security: No impact.
Testing
The changes were validated using existing driver test cases under testing/drivers, in QEMU、sim
and other physical device。apps/testing/drivers/drivertest/drivertest_timer.c
cmocka build case: drivertest_timer