NIFI-14272 - Refactoring MongoDB client creation #9723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exceptionfactory
requested changes
Feb 17, 2025
Contributor
exceptionfactory
left a comment
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for the improvement to the client settings construction @pvillard31. I noted one minor adjustment recommendation for readability, but otherwise this looks good.
| final String database = cs.getDatabase(); | ||
|
|
||
| if (user != null && passw != null) { | ||
| builder.credential(MongoCredential.createCredential(user, database == null ? database : "admin", passw.toCharArray())); |
Contributor
There was a problem hiding this comment.
Recommend declaring a separate variable named authenticationDatabase instead of having the inline ternary.
Contributor
Author
There was a problem hiding this comment.
Thanks, I pushed a commit to address your comment... the database name evaluation was wrong so I fixed this as well...
exceptionfactory
approved these changes
Feb 17, 2025
Contributor
exceptionfactory
left a comment
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for making the adjustment and correcting the database handling, the latest version looks good! +1 merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-14272 - Refactoring MongoDB client creation
Small refactor for the creation of the MongoDB client to better leverage the MongoClientSettings builder.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation