Skip to content

Conversation

@exceptionfactory
Copy link
Contributor

Summary

NIFI-11029 Adds standard XML parsing to ExtractCCDAAttributes using the nifi-xml-processing library and includes an additional unit test for invalid documents.

Additional changes include adding the DeprecationNotice annotation to ExtractCCDAAttributes, recommending that usage of the Processor should be changed to record-oriented handling.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 8
    • JDK 11
    • JDK 17

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

- Added DeprecationNotice to ExtractCCDAAttributes
@mattyb149
Copy link
Contributor

+1 LGTM, thanks for the improvement! Merging to main

@mattyb149 mattyb149 closed this in e966336 Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants