Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[master][clang-format] Re-format cc. .h. .cu files; cond. #20704

Merged
bgawrych merged 10 commits into from
Nov 19, 2021
Merged

[master][clang-format] Re-format cc. .h. .cu files; cond. #20704

bgawrych merged 10 commits into from
Nov 19, 2021

Conversation

@mozga-intel
Copy link
Contributor

@mozga-intel mozga-intel commented Oct 26, 2021

Description

This pull-request contains clang-format changes.

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@mxnet-bot
Copy link

mxnet-bot commented Oct 26, 2021

Hey @mozga-intel , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [unix-gpu, edge, windows-gpu, sanity, centos-gpu, website, miscellaneous, clang, unix-cpu, windows-cpu, centos-cpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 26, 2021
@mozga-intel mozga-intel marked this pull request as draft October 26, 2021 20:14
@mozga-intel mozga-intel force-pushed the mozga-intel/break_before_tenary branch from 94b3f90 to eaa0a3b Compare November 2, 2021 20:32
@mozga-intel
Copy link
Contributor Author

mozga-intel commented Nov 3, 2021

@mxnet-bot run ci [centos-gpu, unix-cpu, unix-gpu, windows-gpu]

@mxnet-bot
Copy link

mxnet-bot commented Nov 3, 2021

Jenkins CI successfully triggered : [unix-cpu, centos-gpu, windows-gpu, unix-gpu]

@mozga-intel
Copy link
Contributor Author

mozga-intel commented Nov 3, 2021

@mxnet-bot run ci [unix-cpu]

@mxnet-bot
Copy link

mxnet-bot commented Nov 3, 2021

Jenkins CI successfully triggered : [unix-cpu]

@mozga-intel mozga-intel force-pushed the mozga-intel/break_before_tenary branch from a293008 to 704f524 Compare November 4, 2021 09:06
@mozga-intel mozga-intel marked this pull request as ready for review November 4, 2021 09:07
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Nov 4, 2021
@mozga-intel mozga-intel force-pushed the mozga-intel/break_before_tenary branch from 704f524 to cc9b6d9 Compare November 4, 2021 09:27
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Nov 4, 2021
@mozga-intel mozga-intel force-pushed the mozga-intel/break_before_tenary branch from 13d0a41 to 9599fab Compare November 5, 2021 07:47
@mozga-intel mozga-intel force-pushed the mozga-intel/break_before_tenary branch from 8420716 to ff48249 Compare November 18, 2021 09:13
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-review PR is waiting for code review pr-awaiting-testing PR is reviewed and waiting CI build and test labels Nov 18, 2021
@mxnet-bot
Copy link

mxnet-bot commented Nov 18, 2021

Jenkins CI successfully triggered : [centos-cpu]

@mozga-intel
Copy link
Contributor Author

mozga-intel commented Nov 18, 2021

@mxnet-bot run ci [unix-cpu]

@mxnet-bot
Copy link

mxnet-bot commented Nov 18, 2021

Jenkins CI successfully triggered : [unix-cpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Nov 18, 2021
bgawrych
bgawrych approved these changes Nov 18, 2021
View reviewed changes
Copy link
Contributor

@bgawrych bgawrych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe issue for tracking this "param" issue should be created?

@mozga-intel
Copy link
Contributor Author

mozga-intel commented Nov 18, 2021

@mxnet-bot run ci [unix-gpu]

@mxnet-bot
Copy link

mxnet-bot commented Nov 18, 2021

Jenkins CI successfully triggered : [unix-gpu]

@mozga-intel
Copy link
Contributor Author

mozga-intel commented Nov 18, 2021

@mxnet-bot run ci [windows-gpu]

@mxnet-bot
Copy link

mxnet-bot commented Nov 18, 2021

Jenkins CI successfully triggered : [windows-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Nov 18, 2021
@mozga-intel
Copy link
Contributor Author

mozga-intel commented Nov 18, 2021

@mxnet-bot run ci [windows-gpu]

@mxnet-bot
Copy link

mxnet-bot commented Nov 18, 2021

Jenkins CI successfully triggered : [windows-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-merge Review and CI is complete. Ready to Merge and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Nov 18, 2021
@bgawrych bgawrych merged commit 1add250 into apache:master Nov 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@aaronmarkham aaronmarkham Awaiting requested review from aaronmarkham aaronmarkham is a code owner

@eric-haibin-lin eric-haibin-lin Awaiting requested review from eric-haibin-lin eric-haibin-lin is a code owner

@nswamy nswamy Awaiting requested review from nswamy nswamy is a code owner

2 more reviewers

@szha szha szha approved these changes

@bgawrych bgawrych bgawrych approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr-awaiting-merge Review and CI is complete. Ready to Merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mozga-intel @mxnet-bot @szha @bgawrych @mseth10