Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[submodule] Upgrade oneDNN to v2.2 #20080

Merged
akarbown merged 1 commit into from
Apr 29, 2021
Merged

[submodule] Upgrade oneDNN to v2.2 #20080

akarbown merged 1 commit into from
Apr 29, 2021

Conversation

@bartekkuncer
Copy link
Contributor

@bartekkuncer bartekkuncer commented Mar 23, 2021 •
edited
Loading

Description

This change simply upgrades oneDNN used in MXNet to v2.2.

Checklist

Changes

  • Upgrade oneDNN used in MXNet to v2.2.1

Comments

  • This change involves removal of a descriptor check and replacing it with explicite data reordering

@mxnet-bot
Copy link

mxnet-bot commented Mar 23, 2021

Hey @bartekkuncer , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [edge, unix-cpu, windows-cpu, centos-cpu, miscellaneous, website, sanity, clang, windows-gpu, unix-gpu, centos-gpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added the pr-work-in-progress PR is still work in progress label Mar 23, 2021
@bartekkuncer
Copy link
Contributor Author

bartekkuncer commented Mar 23, 2021

@mxnet-bot run ci [windows-cpu]

@mxnet-bot
Copy link

mxnet-bot commented Mar 23, 2021

Jenkins CI successfully triggered : [windows-cpu]

@bartekkuncer
Copy link
Contributor Author

bartekkuncer commented Apr 23, 2021

@mxnet-bot run ci [windows-cpu]

@mxnet-bot
Copy link

mxnet-bot commented Apr 23, 2021

Jenkins CI successfully triggered : [windows-cpu]

@bartekkuncer bartekkuncer marked this pull request as ready for review April 23, 2021 14:44
@bartekkuncer bartekkuncer marked this pull request as draft April 23, 2021 14:46
@bartekkuncer bartekkuncer marked this pull request as ready for review April 26, 2021 11:11
@bartekkuncer
Copy link
Contributor Author

bartekkuncer commented Apr 26, 2021

@szha Please help with the merge.

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels Apr 28, 2021
@szha szha requested a review from akarbown April 28, 2021 14:31
@mseth10 mseth10 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Apr 28, 2021
@bartekkuncer
Copy link
Contributor Author

bartekkuncer commented Apr 29, 2021

@mxnet-bot run ci [windows-cpu, centos-cpu,unix-cpu,unix-gpu]

@mxnet-bot
Copy link

mxnet-bot commented Apr 29, 2021

Jenkins CI successfully triggered : [windows-cpu, centos-cpu, unix-gpu, unix-cpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-merge Review and CI is complete. Ready to Merge and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Apr 29, 2021
@akarbown akarbown merged commit c3e0d99 into apache:master Apr 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@szha szha szha approved these changes

@akarbown akarbown akarbown approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr-awaiting-merge Review and CI is complete. Ready to Merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@bartekkuncer @mxnet-bot @szha @akarbown @lanking520 @mseth10