Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[1.8.x][submodule] Upgrade to oneDNN v1.7 #19560

Merged
pengzhao-intel merged 3 commits into from
Nov 24, 2020
Merged

[1.8.x][submodule] Upgrade to oneDNN v1.7 #19560

pengzhao-intel merged 3 commits into from
Nov 24, 2020

Conversation

@bartekkuncer
Copy link
Contributor

@bartekkuncer bartekkuncer commented Nov 18, 2020

Upgrade oneDNN used on v1.8.x branch to v1.7.

@mxnet-bot
Copy link

mxnet-bot commented Nov 18, 2020

Hey @bartekkuncer , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [windows-gpu, clang, sanity, centos-gpu, unix-gpu, centos-cpu, website, miscellaneous, windows-cpu, edge, unix-cpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Nov 18, 2020
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Nov 18, 2020
@bartekkuncer
Copy link
Contributor Author

bartekkuncer commented Nov 19, 2020

@leezu @szha Please help with the merge. This change only upgrades oneDNN to v1.7.

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Nov 19, 2020
@szha
Copy link
Member

szha commented Nov 19, 2020

@mxnet-bot run ci [centos-gpu]

@mxnet-bot
Copy link

mxnet-bot commented Nov 19, 2020

Jenkins CI successfully triggered : [centos-gpu]

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Nov 19, 2020
@bartekkuncer
Copy link
Contributor Author

bartekkuncer commented Nov 23, 2020

@szha As all tests passed can this change be merged? 😄

@leezu
Copy link
Contributor

leezu commented Nov 23, 2020

cc @samskalicky

@leezu leezu requested review from samskalicky and removed request for anirudh2290 November 23, 2020 18:39
@pengzhao-intel
Copy link
Contributor

pengzhao-intel commented Nov 24, 2020

@bartekkuncer is this ready to merge?

pengzhao-intel
pengzhao-intel approved these changes Nov 24, 2020
View reviewed changes
Copy link
Contributor

@pengzhao-intel pengzhao-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartekkuncer
Copy link
Contributor Author

bartekkuncer commented Nov 24, 2020

@bartekkuncer is this ready to merge?

@pengzhao-intel Yes.

@pengzhao-intel pengzhao-intel merged commit 2ad91d2 into apache:v1.8.x Nov 24, 2020
@bartekkuncer bartekkuncer deleted the oneDNN1.71.8 branch November 24, 2020 13:12
@bartekkuncer bartekkuncer mentioned this pull request Nov 26, 2020
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@samskalicky samskalicky Awaiting requested review from samskalicky

1 more reviewer

@pengzhao-intel pengzhao-intel pengzhao-intel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr-awaiting-review PR is waiting for code review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@bartekkuncer @mxnet-bot @szha @leezu @pengzhao-intel @lanking520