KAFKA-19809 CheckStyle version upgrade: 10 -->> 12

[dejan2609]

Jira ticket: KAFKA-19809

Related link: https://checkstyle.org/releasenotes.html#Release_12.2.0

⚠️ quick and dirty (aka skeleton) solution

Reviews are welcome!

Relates to: checkstyle/checkstyle#16003

Reviewers: Chia-Ping Tsai chia7712@gmail.com

[dejan2609]

Options:

1. increase limit (like here)
2. create a baseline (skip/suppress this check for existing cases/classes)
3. change existing classes and keep the old property value max limit

[dejan2609]

From my POV both of these checks are overzealous and hence I turned them off, but I'm open to a discussion.

Related links:

• https://checkstyle.sourceforge.io/checks/misc/finalparameters.html
• https://checkstyle.sourceforge.io/checks/coding/finallocalvariable.html
• https://softwareengineering.stackexchange.com/questions/48413/in-java-should-i-use-final-for-parameters-and-locals-even-when-i-dont-have-t
• https://stackoverflow.com/questions/3635863/why-method-parameters-needs-to-be-set-as-final
• https://stackoverflow.com/questions/500508/why-should-i-use-the-keyword-final-on-a-method-parameter-in-java
• https://www.reddit.com/r/learnjava/comments/1ffoa9p/using_final_in_method_parameters_your_opinion

[dejan2609]

Can you please take a look @chia7712 ?

[dejan2609]

It seems that this PR has to be rebased onto trunk (to avoid Could not find build scan errors).

[dejan2609]

Options:

1. increase limit (like here)
2. create a baseline (skip/suppress this check for existing cases/classes)
3. change existing classes and keep the old property value max limit

[romani]

After this PR is any form is merged, checkstyle team will start using Kafka repository code base in regression testing.
If Kafka team keeps no checkstyle errors strictly enforced, checkstyle team will send PR each time there is additional fixes are required that will be released in in future.

So update of checkstyle version will be just version number bump.

[romani]

@dejan2609 , please resolve conflict.

[romani]

Checkstyle team merged integration of Kafka validation over by checkstyle for each pull request to checkstyle.

Any changes in behavior that results in extra violations on Kafka code base will result in PR from checkstyle team to Kafka to be merged before checkstyle accept PR checkstyle code base.

[chia7712]

LGTM