Skip to content

CI: some CI workers are slow, so use bigger margin for test duration #6662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FSchumacher merged 1 commit into from
Mar 19, 2026
+2 −2
Merged

CI: some CI workers are slow, so use bigger margin for test duration #6662

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions bin/testfiles/TestSchedulerWithTimer.jmx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<jmeterTestPlan version="1.2" properties="3.2" jmeter="3.2-SNAPSHOT.20170410">
<hashTree>
<TestPlan guiclass="TestPlanGui" testclass="TestPlan" testname="Test Plan" enabled="true">
<stringProp name="TestPlan.comments">Each Thread Group should initially end after 20s but since scheduler is set to 5s, we check it ends within 6s. Tests for Bugs 60797 and 60049</stringProp>
<stringProp name="TestPlan.comments">Each Thread Group should initially end after 20s but since scheduler is set to 5s, we check it ends within 7s (some CI workers are slow). Tests for Bugs 60797 and 60049</stringProp>
<boolProp name="TestPlan.functional_mode">false</boolProp>
<boolProp name="TestPlan.serialize_threadgroups">false</boolProp>
<elementProp name="TestPlan.user_defined_variables" elementType="Arguments" guiclass="ArgumentsPanel" testclass="Arguments" testname="User Defined Variables" enabled="true">
Expand Down Expand Up @@ -170,7 +170,7 @@
<stringProp name="cacheKey">7b043ed3-cbc5-4b9c-8427-8c70e6791c07</stringProp>
<stringProp name="script">long start = Long.parseLong(props.get(&quot;TEST_START&quot;));
long duration = System.currentTimeMillis() - start;
long maxDurationPlusMargin = vars[&quot;MaxDuration&quot;].toInteger()*1000+1000;
long maxDurationPlusMargin = vars[&quot;MaxDuration&quot;].toInteger()*1000+2000;
if(duration&gt; maxDurationPlusMargin) {
SampleResult.setSuccessful(false);
SampleResult.setResponseData(&quot;Duration &quot;+duration+&quot; exceeded expected duration of &quot;+maxDurationPlusMargin);
Expand Down
Loading