Merged
Conversation
CamilleTeruel
force-pushed
the
improve_test_connection
branch
3 times, most recently
from
b2e3043 to
20aa816
Compare
keon94
reviewed
Mar 20, 2023
| def remote_scope_groups(self, ctx) -> list[RemoteScopeGroup]: | ||
| api = AzureDevOpsAPI(ctx.connection) | ||
| member_id = api.my_profile.json['id'] | ||
| def remote_scope_groups(self, connection) -> list[RemoteScopeGroup]: |
keon94
reviewed
Mar 20, 2023
|
|
||
| func (pa *pluginAPI) TestConnection(input *plugin.ApiResourceInput) (*plugin.ApiResourceOutput, errors.Error) { | ||
| err := pa.invoker.Call("test-connection", bridge.DefaultContext, input.Body).Err | ||
| if err != nil { |
Contributor
There was a problem hiding this comment.
we can't assume the error will always be 401. What if the endpoint was offline or gave us another error code? I think TestConnection needs to have a contract where it writes the datasource's response into a standardized output with a Http Code on it. It might as well be the ApiResourceOutput struct, but written for Python.
Contributor
Author
There was a problem hiding this comment.
Indeed, this would require to discriminate between errors. We can plan this change for later.
For now the message helps disambiguate.
CamilleTeruel
force-pushed
the
improve_test_connection
branch
from
406a332 to
ef46f06
Compare
Contributor
|
LGTM |
added 6 commits
March 20, 2023 22:54
Since we are not saving the connection at that time there is no need to enforce that DB constrain.
More consistent with other plugins.
Allow to supply an empty str as proxy in connections. More constistent with other plugins.
keon94
force-pushed
the
improve_test_connection
branch
from
ef46f06 to
254ef6c
Compare
keon94
approved these changes
Mar 21, 2023
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pattotokenproxy