feat(config-ui): support plugin azure devops#4504
Merged
likyh merged 6 commits intoapache:mainfrom Mar 31, 2023
mintsweet:feat-3321
Merged
feat(config-ui): support plugin azure devops#4504likyh merged 6 commits intoapache:mainfrom mintsweet:feat-3321
likyh merged 6 commits intoapache:mainfrom
mintsweet:feat-3321
Conversation
3 tasks
3 tasks
likyh
approved these changes
Mar 31, 2023
| if err != nil { | ||
| return &CallResult{ | ||
| Err: errors.Default.Wrap(err, fmt.Sprintf("failed to invoke remote function \"%s\"", methodName)), | ||
| Err: errors.Default.Wrap(err, fmt.Sprintf("get error when invoking remote function %s", methodName)), |
| Message: err.Error(), | ||
| } | ||
| return &plugin.ApiResourceOutput{Body: body, Status: 401}, nil | ||
| return &plugin.ApiResourceOutput{Body: body, Status: 500}, nil |
Contributor
There was a problem hiding this comment.
It is true that the error can be a server error, but it is more regularly an authorization error from the tool API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
support plugin azure devops.
Does this close any open issues?
Closes #3321
Screenshots