Hide servlet features, should be selected via --servlet instead #15005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the servlet container should be selected via --servlet jetty none tomcat undertow Selecting via features does not properly override ServletImpl
12 tasks
jdaugherty
approved these changes
Aug 22, 2025
matrei
approved these changes
Aug 22, 2025
Contributor
matrei
left a comment
matrei
left a comment
There was a problem hiding this comment.
Should we also simplify the condition in the shouldApply methods of SpringBoot{ServletContainer}Feature classes.
public boolean shouldApply(ApplicationType applicationType, Options options, Set<Feature> selectedFeatures) {
return options.getServletImpl() == ServletImpl.JETTY;
}Refactored the shouldApply method in SpringBootJettyFeature, SpringBootTomcatFeature, and SpringBootUndertowFeature to only check the servlet implementation option, removing the check for feature presence in selectedFeatures. This streamlines the logic and avoids redundant checks.
Contributor
Author
|
@matrei I updated the shouldApply() methods for the 3 servlet container features and retested. They are concise and understandable now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the servlet container should be selected
via --servlet
jetty none tomcat undertow
Selecting via features does not properly override ServletImpl