fix: sitemesh3 rendering #14989
Merged
fix: sitemesh3 rendering #14989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdaugherty
force-pushed
the
sitemesh3-fix
branch
from
89dc07c to
34376dd
Compare
jdaugherty
force-pushed
the
sitemesh3-fix
branch
from
34376dd to
4c425ad
Compare
Contributor
Author
|
I'm epxecting all tests to pass now; here's the local build scan: https://ge.grails.org/s/ogwckaqwujlks |
…having a tag that converts from preprocessed
jamesfredley
approved these changes
Aug 18, 2025
matrei
approved these changes
Aug 19, 2025
Contributor
matrei
left a comment
matrei
left a comment
There was a problem hiding this comment.
Nice James!
What is the purpose of the <body onload="test();"> function call in some of the endToEnd views?
Contributor
Author
Sitemesh parses the html and I think this was meant as the ultimate test to make sure it was handling complicated attributes correctly. I didn't write these tests - they are from the original Sitemesh 2 test code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we were forced to rename sitemesh -> grailsLayout due to the license audit of sitemesh2, it broke sitemesh 3. The tags are being generated still as
grailsLayout:in the GrailsLayoutPreprocessor so sitemesh3's SitemeshTagLib needs to use the same namespace.