-
-
Notifications
You must be signed in to change notification settings - Fork 969
Cleanup broken documentation links, update links which have changed, standardize link syntax #14988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdaugherty
requested changes
Aug 18, 2025
Contributor
jdaugherty
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great Job!
My only concern is:
The license and notice files have to match exactly since it is spelled out that way in the licenses. We can change headers, etc, but I don't believe we can change the LICENSE and NOTICE files
# Conflicts: # grails-forge/grails-forge-core/src/main/java/org/grails/forge/feature/reloading/Springloaded.java
jdaugherty
approved these changes
Aug 20, 2025
This was referenced Aug 20, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This started by evaluating broken links in grails-doc, but expanded from there to correct the same URLs across the project. It updates grails.org URLs to grails.apache.org and updates all links, which can be changed, to https.
In some cases the best available URL was used to replace one that returned a 404. In the rare case where there was no URL available, like in the instance of a 15 year old blog post, the URL was removed.
It now represents around 1,000 fixed or updated URLs.
There are a few
grails.util.*api links which still 404, due to #14978Broken links were identified and verified as fixed using https://github.com/lycheeverse/lychee/releases/tag/lychee-v0.19.1.
grails-data and groovydocs were skipped and issues will be created to work on those broken URLs. #14990 & #14991
review
results.mdHere is the summary from the latest run. https://dev.mysql.com/downloads/connector/j/ are false positives.
Summary