-
-
Notifications
You must be signed in to change notification settings - Fork 969
chore: add versioning section to RELEASE.md and a link in README.md #14962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Great Job @cbmarcum. While this explains our versioning scheme, it does not address ASF 'release' confusion. @jamesfredley @matrei Should we add something that clarifies why we put out releases this way? I think @jamesfredley linked to Spring's guide as one example; should we mention that we base our versioning off Spring too? I'm also ok with only adding this and addressing these concerns outside of the code. |
README.md
Outdated
|
|
||
| ## Versioning | ||
|
|
||
| The Apache Grails versioning scheme is defined in [RELEASE.md Appendix: Versioning](https://github.com/apache/grails-core/blob/7.0.x/RELEASE.md#appendix-versioning). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can get away with just the following here, which saves us from adjusting the branch going forward.
[RELEASE.md Appendix: Versioning](RELEASE.md#appendix-versioning)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I'll make the adjustments.
|
I think adding a sentence stating that we follow the Spring release versioning scheme, with or without link, and that we release soon after each Spring Boot release, would add clarity. And a sentence distinguishing between a RCX release and a release candidate from the ASF release process perfective. |
|
@jamesfredley, @jdaugherty, and All, let me know what you think of the modifications. |
…d RELEASE.md to mention following Spring and differences in definitions with ASF. Refs: apache#14959
eb51786 to
508d67f
Compare
Refs: #14959