Various Cleanup prior to Sitemesh 2 revert #14876
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
Author
|
The last 3 commits of this request allow us to decouple the sitemesh2 revert so that in the future plugins compiled with Grails 7 aren't broken if we revert back. |
jdaugherty
force-pushed
the
issue14193Cleanup
branch
from
6f9c4f3 to
7589fca
Compare
jdaugherty
force-pushed
the
issue14193Cleanup
branch
from
7589fca to
24db59d
Compare
matrei
reviewed
Jul 5, 2025
grails-test-examples/gsp-layout/src/integration-test/groovy/EndToEndSpec.groovy
Outdated
Show resolved
Hide resolved
grails-test-examples/gsp-layout/src/integration-test/groovy/EndToEndSpec.groovy
Outdated
Show resolved
Hide resolved
grails-test-examples/gsp-layout/src/integration-test/groovy/EndToEndSpec.groovy
Outdated
Show resolved
Hide resolved
grails-test-examples/gsp-layout/src/integration-test/groovy/EndToEndSpec.groovy
Outdated
Show resolved
Hide resolved
grails-test-examples/gsp-layout/src/integration-test/groovy/EndToEndSpec.groovy
Outdated
Show resolved
Hide resolved
...amples/app1/src/integration-test/groovy/functionaltests/layout/NoLayoutControllerSpec.groovy
Outdated
Show resolved
Hide resolved
grails-test-examples/app1/src/integration-test/groovy/functionaltests/ForwardingSpec.groovy
Outdated
Show resolved
Hide resolved
grails-test-examples/app1/src/integration-test/groovy/functionaltests/ForwardingSpec.groovy
Outdated
Show resolved
Hide resolved
grails-test-examples/app1/grails-app/controllers/functionaltests/ForwardingController.groovy
Outdated
Show resolved
Hide resolved
grails-testing-support-datamapping/src/main/groovy/grails/testing/gorm/DataTest.groovy
Outdated
Show resolved
Hide resolved
jdaugherty
force-pushed
the
issue14193Cleanup
branch
from
a20b528 to
fceb843
Compare
matrei
reviewed
Jul 5, 2025
...ls3-neo4j-hibernate/src/integration-test/groovy/functional/tests/AuthorControllerSpec.groovy
Outdated
Show resolved
Hide resolved
matrei
reviewed
Jul 5, 2025
...xamples/grails3-neo4j/src/integration-test/groovy/functional/tests/BookControllerSpec.groovy
Outdated
Show resolved
Hide resolved
jdaugherty
force-pushed
the
issue14193Cleanup
branch
from
107f771 to
514bb2a
Compare
matrei
reviewed
Jul 5, 2025
...ls-test-examples/app1/src/integration-test/groovy/functionaltests/AsyncFunctionalSpec.groovy
Outdated
Show resolved
Hide resolved
matrei
reviewed
Jul 5, 2025
...test-examples/app1/src/integration-test/groovy/functionaltests/ControllerIncludesSpec.groovy
Show resolved
Hide resolved
matrei
reviewed
Jul 5, 2025
...s-test-examples/app1/src/integration-test/groovy/functionaltests/ErrorsFunctionalSpec.groovy
Show resolved
Hide resolved
matrei
reviewed
Jul 5, 2025
grails-test-examples/app1/src/integration-test/groovy/functionaltests/MiscFunctionalSpec.groovy
Show resolved
Hide resolved
matrei
reviewed
Jul 5, 2025
...test-examples/app1/src/integration-test/groovy/functionaltests/RedirectIntercetorSpec.groovy
Outdated
Show resolved
Hide resolved
matrei
reviewed
Jul 5, 2025
grails-test-examples/app2/src/integration-test/groovy/app2/ErrorsControllerSpec.groovy
Outdated
Show resolved
Hide resolved
matrei
reviewed
Jul 5, 2025
grails-test-examples/cache/src/integration-test/groovy/com/demo/CacheTagIntegrationSpec.groovy
Show resolved
Hide resolved
matrei
reviewed
Jul 5, 2025
...amples/cache/src/integration-test/groovy/com/demo/NotCachingControllerIntegrationSpec.groovy
Show resolved
Hide resolved
matrei
reviewed
Jul 5, 2025
grails-test-examples/geb/src/integration-test/groovy/org/demo/spock/InheritedConfigSpec.groovy
Outdated
Show resolved
Hide resolved
matrei
reviewed
Jul 5, 2025
grails-test-examples/app1/src/integration-test/groovy/functionaltests/MiscFunctionalSpec.groovy
Outdated
Show resolved
Hide resolved
matrei
reviewed
Jul 5, 2025
grails-test-examples/cache/src/integration-test/groovy/com/demo/CacheTagIntegrationSpec.groovy
Show resolved
Hide resolved
matrei
reviewed
Jul 5, 2025
grails-test-examples/gsp-layout/src/integration-test/groovy/GrailsLayoutSpec.groovy
Show resolved
Hide resolved
jdaugherty
force-pushed
the
issue14193Cleanup
branch
from
2cd6401 to
c69a8a4
Compare
jdaugherty
force-pushed
the
issue14193Cleanup
branch
from
94b28e6 to
48db336
Compare
jdaugherty
force-pushed
the
issue14193Cleanup
branch
from
48db336 to
69f1cf4
Compare
matrei
approved these changes
Jul 6, 2025
davydotcom
approved these changes
Jul 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of these changes were originally in PR #14875
This moves everything non-sitemesh2 related - such as test pollution prevention, styling cleanup, doc cleanup, test updates, added test coverage that was removed in the original revert, and decoupling so either can be used in the future if we decide