Update grails-static-website section on RELEASE.md #14807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates documentation in RELEASE.md by replacing hard-coded branch links with HEAD and expanding the steps for updating the grails-static-website when cutting a new release.
- Changed links pointing at
7.0.xto useHEAD - Expanded the “Update the grails-static-website” section with concrete steps
Comments suppressed due to low confidence (3)
RELEASE.md:252
- Using
HEADmay introduce ambiguity if the default branch changes. Consider linking to the specific release branch (e.g.,7.0.x) or using a variable placeholder for clarity and long-term stability.
Details of our release process is documented at: https://github.com/apache/grails-core/blob/HEAD/RELEASE.md
RELEASE.md:354
- [nitpick] The new steps appear as prose rather than list items, which may break the existing list formatting. Consider prefixing each step with a dash (
-) or numbering them for consistency with the rest of the document.
On the `grails-static-website` repository:
RELEASE.md:356
- The phrase is ambiguous about what happens at
grails.apache.org. It may help to clarify that the workflow both publishes the branch and deploys the site to that URL.
This will trigger publishing to the `asf-site-production` branch and https://grails.apache.org
jdaugherty
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.