Verify build explanation and minor fix #14781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… directory that was wrong
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the release instructions by clarifying how to locate the staging repository ID in the GitHub Actions workflow and fixes an unintended character in the comment header.
- Adds detailed steps to find the staging repo ID in GitHub Actions.
- Removes an accidental leading character from the top comment.
Comments suppressed due to low confidence (1)
RELEASE.md:1
- The leading 'x' before '<!--' appears unintended and breaks the markdown comment syntax; remove the 'x' to restore a proper HTML comment.
x<!--
jdaugherty
reviewed
Jun 4, 2025
jdaugherty
approved these changes
Jun 4, 2025
Contributor
|
Please do not merge this until after M4 has been released since we're waiting on the vote. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
jdaugherty
reviewed
Jun 4, 2025
| } | ||
| trap error ERR | ||
|
|
||
| cd "${DOWNLOAD_LOCATION}" |
Contributor
There was a problem hiding this comment.
Ah, I always had the download_location = current directory in my testing. Good catch!
jdaugherty
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added explanation on how to find staging repo id, and fixed a current directory that was wrong