Skip to content

refactor: eslint setup#23

Merged
erisu merged 1 commit intoapache:masterfrom
erisu:v4-eslint
Nov 15, 2019
Merged

refactor: eslint setup#23
erisu merged 1 commit intoapache:masterfrom
erisu:v4-eslint

Conversation

@erisu
Copy link
Copy Markdown
Member

@erisu erisu commented Nov 14, 2019

Motivation and Context

Code syntax cleanup

Description

  • replace dependencies with @cordova/eslint-config
  • update eslint config
  • eslint corrections

Testing

  • npm t
  • npm run lint

Checklist

  • I've run the tests to see all new and existing tests pass

@erisu erisu added this to the 4.0.0 milestone Nov 14, 2019
@erisu erisu requested a review from raphinesse November 14, 2019 08:58
@timbru31
Copy link
Copy Markdown
Member

timbru31 commented Nov 14, 2019

Of course, please wait until CI passes ;)

@erisu
Copy link
Copy Markdown
Member Author

erisu commented Nov 14, 2019

The failing node 6 will be fixed when I merge in the other PRs to bump the version and drop node 6 and 8. It just happens to fail because the version of the ESLint uses the new syntax.

@erisu
refactor: eslint setup
4dd94a9 
* replace dependencies with @cordova/eslint-config
* update eslint config
* eslint corrections
@erisu erisu merged commit b5d446e into apache:master Nov 15, 2019
@erisu erisu deleted the v4-eslint branch November 15, 2019 02:10
@raphinesse raphinesse mentioned this pull request Nov 27, 2019
Open
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timbru31 timbru31 timbru31 approved these changes

@raphinesse raphinesse raphinesse approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@erisu @timbru31 @raphinesse