fix(android): allow compilation in old cordova-android versions#803
fix(android): allow compilation in old cordova-android versions#803jcesarmobile merged 1 commit intoapache:masterfrom
Conversation
|
I'm assuming this will cause breakage if running on later android targets. We should probably attempt to get this patch and the new major released around the same time. |
|
no, it should still work on any capacitor-android version, even on newer ones, it just replaces constants which might not exist with the number they represent |
timbru31
left a comment
There was a problem hiding this comment.
Not really a big fan of introducing magic numbers, the Android constants exists for a reason and make reading the code a lot easier.
|
Yeah, this is a temporary fix, will revert it once released |
since the plugin don't have engines for cordova-android, people is using it in old cordova-android versions and it fails to compile because it uses some code that is not supported in older SDK compile versions.
This PR should make it compile in older versions (tested only 6.2.3 which targets android-25, could still fail in even older versions)
closes #554
after this is merged we should do a patch/minor release and then we can revert and set the engines to cordova-android 9 and remove a lot of code that wouldn't be needed, and then do a major release as updating the engines is a breaking change