(iOS) fixing problem status bar frame too narrow#638
Closed
kutoman wants to merge 1 commit intoapache:masterfrom
Closed
(iOS) fixing problem status bar frame too narrow#638kutoman wants to merge 1 commit intoapache:masterfrom
kutoman wants to merge 1 commit intoapache:masterfrom
Conversation
this approach considers the safe area insets
Member
|
The CI failure was unrelated, I've restarted the affected build and now it's green. |
Author
|
#546 handles the same issue differently |
Contributor
|
I test it but this need to some modifications. Anyway you can close your pull request because someone made a well tested pull request that will be merged to master in the future: |
Merged
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this approach considers the safe area insets
Platforms affected
iOS
Motivation and Context
This change prevents from hardcoding the status bar frame size.
It doesn't really fix any open issue as far as I could see.
Description
the status bar frame was too narrow so that some symbols of the iPhone XR statusbar weren't
contained by the frame fully.
Testing
tested it in iPhone 8 and iPhone XR simulators
Checklist
(platform)if this change only applies to one platform (e.g.(android))