Skip to content

(ios) removing hard coded height#629

Closed
MoemenMostafa wants to merge 1 commit intoapache:masterfrom
MoemenMostafa:patch-1
Closed

(ios) removing hard coded height#629
MoemenMostafa wants to merge 1 commit intoapache:masterfrom
MoemenMostafa:patch-1

Conversation

@MoemenMostafa
Copy link
Copy Markdown

Platforms affected

iOS

Motivation and Context

The hard coded height is causing a problem in phones with notch when this plugin used without the statusbar plugin.
#301

Description

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

The hard coded height is causing a problem in phones with notch when this plugin used without the statusbar plugin.
@NiklasMerz
Copy link
Copy Markdown
Member

We already have similar attempts for the status bar on devices with a notch: #546

But we want to remove this "fake statusbar" altogether soon #604

@NiklasMerz
Copy link
Copy Markdown
Member

The statusbar has been removed in #656

@NiklasMerz NiklasMerz closed this Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants