Android GH-470 InAppBrowser: java.lang.IllegalArgumentException#616
Merged
timbru31 merged 1 commit intoapache:masterfrom Mar 20, 2020
Merged
Android GH-470 InAppBrowser: java.lang.IllegalArgumentException#616timbru31 merged 1 commit intoapache:masterfrom
timbru31 merged 1 commit intoapache:masterfrom
Conversation
Fix interacting with views when Activity destroyed Bug description https://stackoverflow.com/questions/22924825/view-not-attached-to-window-manager-crash
timbru31
approved these changes
Mar 17, 2020
Member
timbru31
left a comment
timbru31
left a comment
There was a problem hiding this comment.
Thanks for the PR!
LGTM. I'd like to get a second review though.
Member
|
Merging now. Since this has no real repro, we should monitor if we still receive IllegalArgumentExceptions. In this case, we can further guard the dismiss check with This also closes CB-12754. |
5 tasks
expertanswerz
pushed a commit
to expertanswerz/cordova-plugin-inappbrowser
that referenced
this pull request
Apr 9, 2020
* master: docs: replaces outdated transition and presentation style links (apache#662) chore: remove deprecated orientation methods (apache#666) Fix incorrect TypeScript typings (apache#515) [apacheGH-652] add check for openInSystem postNotification (apache#654) ci: updates Node.js versions (apache#659) chore(npm): improve ignore list (apache#658) fix(android): Reset lefttoright if not set (apache#442) [android] Correcting the documentation regarding lefttoright opt… (apache#648) (android) Added option to turn on/off fullscreen mode in Android (apache#634) Android apacheGH-470 InAppBrowser: java.lang.IllegalArgumentException (apache#616) breaking(ios): remove UIWebView (apache#635) chore(release): 3.2.1-dev
rufiange
pushed a commit
to jalios/cordova-plugin-inappbrowser
that referenced
this pull request
Apr 15, 2020
…apache#616) Fix interacting with views when Activity destroyed Bug description https://stackoverflow.com/questions/22924825/view-not-attached-to-window-manager-crash Co-authored-by: Sarafanov Valeriy <sarafanov_v@firma-gamma.ru>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix interacting with views when Activity destroyed
Bug description https://stackoverflow.com/questions/22924825/view-not-attached-to-window-manager-crash
Platforms affected
Android
Motivation and Context
Closes #470
Description
Fix check is activity not destroyed before interacting with it
Testing
As described in https://github.com/apache/cordova-plugin-inappbrowser/blob/master/CONTRIBUTING.md
Checklist
I can`t reproduce the problem. But this commit stop error messages in Firebase Crashlitics
(platform)if this change only applies to one platform (e.g.(android))(not necessary)