Move bridge creation to injectDeferredObject#401
Merged
dpa99c merged 1 commit intoapache:masterfrom Sep 24, 2019
Merged
Conversation
Avoid failed script injections for pages which did not finish loading.
NiklasMerz
changed the title
Member
Author
|
Any chance to get this reviewed anytime soon? Looks like a regression to me. |
Contributor
|
Yep, simple change and no reason to create the bridge before injection on UIWebview variant (which is imminently going away soon anyway). |
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms affected
iOS
What does this PR do?
This avoids failed script injections for pages which did not finish loading.
Version 3.0.0 created the iframe like that and the refactor for WKWebView changes this. Now the iframe won´t be created for pages which cannot finish loading and injected javascript will fail.
What testing has been done on this change?
Tested inject javascript on pages which cannot load.
Checklist