(iOS) Fix for infinite loop reported in issue #591#592
Closed
sherburne wants to merge 1 commit intoapache:masterfrom
Closed
(iOS) Fix for infinite loop reported in issue #591#592sherburne wants to merge 1 commit intoapache:masterfrom
sherburne wants to merge 1 commit intoapache:masterfrom
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms affected
iOS 13.x.
Motivation and Context
The
do..whileloop intempFilePathhas the potential to be infinite if the plugin is also configured withCameraUsesGeolocationset to TRUE and the user is capturing an image from the camera. I've reported this in issue #591.Description
The infinite condition can be easily avoided by moving the initialization of
filePathinto the loop. The underlying problem is thattimeIntervalSince1970only has second granularity, howevertempFilePathis called twice when capturing a picture when geolocation is enabled.Testing
Tested on a base Cordova install running on iOS 13.x.
Checklist
(platform)if this change only applies to one platform (e.g.(android))