CLOUDSTACK-10227: Add delay before reverting VM snapshot#2407
Merged
yadvr merged 1 commit intoapache:4.11from Jan 15, 2018
Merged
CLOUDSTACK-10227: Add delay before reverting VM snapshot#2407yadvr merged 1 commit intoapache:4.11from
yadvr merged 1 commit intoapache:4.11from
Conversation
As discovered and discussed in apache#2376, adding some delay after stopping the VM and reverting VM snapshot passes the `test_change_service_offering_for_vm_with_snapshots` test case. The suspect here is userVMDao or background vmsync that may not update the VM state to PowerOff. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
DaanHoogland
approved these changes
Jan 15, 2018
borisstoyanov
approved these changes
Jan 15, 2018
Contributor
borisstoyanov
left a comment
borisstoyanov
left a comment
There was a problem hiding this comment.
LGTM, I've experienced this in other tests as well, sometimes cloudstack needs some sleep time to sync.
Member
Author
|
Thanks @DaanHoogland @borisstoyanov . I'll merge this now and start RC1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discovered and discussed in #2376, adding some delay after stopping
the VM and reverting VM snapshot passes the
test_change_service_offering_for_vm_with_snapshotstest case. Thesuspect here is userVMDao or background vmsync that may not update
the VM state to PowerOff.
Pinging for review @mike-tutkowski @rafaelweingartner @DaanHoogland and others.
Manually verified with QA:
I think since this only changes the test file, it may be accepted only with at least code reviews. It's not a blocker, but fixing this smoketest will avoid getting incorrect failures.