fix: improve AddLink and HasLink with KeyMatch4 pattern performance#801
Merged
hsluoyz merged 1 commit intoapache:masterfrom Jul 8, 2021
Merged
fix: improve AddLink and HasLink with KeyMatch4 pattern performance#801hsluoyz merged 1 commit intoapache:masterfrom
hsluoyz merged 1 commit intoapache:masterfrom
Conversation
Member
|
@giefferre @closetool plz review. |
Member
|
@sagilio will |
Contributor
|
@sagilio Please consider this one. if rm.matchingFunc(namePattern, name1) {
valueRole, _ := rm.roles.LoadOrStore(key.(string), newRole(key.(string)))
valueRole.(*Role).addRole(role1)
}
if rm.matchingFunc(name2, namePattern) {
role2.addRole(value.(*Role))
} |
Contributor
Author
Ok! |
Member
3ac9243 to
0b19a9b
Compare
28f7a17 to
ac47e4a
Compare
Signed-off-by: Sagilio <Sagilio@outlook.com>
giefferre
approved these changes
Jul 7, 2021
|
🎉 This PR is included in version 2.31.10 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: #781 and fix: #829
IssueHunt Summary
Referenced issues
This pull request has been submitted to: