Skip to content

feat: add method GetImplicitResourcesForUser#798

Merged
hsluoyz merged 1 commit intoapache:masterfrom
kilosonc:updateEnhance
May 26, 2021
Merged

feat: add method GetImplicitResourcesForUser#798
hsluoyz merged 1 commit intoapache:masterfrom
kilosonc:updateEnhance

Conversation

@kilosonc
Copy link
Contributor

@kilosonc kilosonc commented May 20, 2021

Signed-off-by: closetool 4closetool3@gmail.com

Fix: #796

@kilosonc
Copy link
Contributor Author

kilosonc commented May 20, 2021

@hsluoyz This method just loop rmMap ,that might not right https://github.com/casbin/casbin/blob/5bdbb063721697233f9128e459a68399888f7bcb/rbac_api.go#L188

@hsluoyz
Copy link
Member

hsluoyz commented May 23, 2021

@closetool we don't need new function. We just need to support g2 in GetImplicitPermissionsForUser().

@kilosonc
Copy link
Contributor Author

kilosonc commented May 24, 2021

@hsluoyz Supporting g2 could not satisfy customer's requirement
apache/casbin-jcasbin#174 (comment)
maybe I'll make a pr later to support g2 in GetPermissionsForUser

@hsluoyz
Copy link
Member

hsluoyz commented May 24, 2021

@closetool rename GetImplicitPoliciesForUser() to GetImplicitResourcesForUser(). Also plz add some tests.

@hsluoyz hsluoyz requested review from sagilio and uran0sH May 24, 2021 09:22
@kilosonc
Copy link
Contributor Author

kilosonc commented May 25, 2021

Fixed @hsluoyz

@hsluoyz
Copy link
Member

hsluoyz commented May 25, 2021

@closetool commit and PR name

@kilosonc kilosonc changed the title feat: add method GetImplicitPoliciesForUser feat: add method GetImplicitResourcesForUser May 25, 2021
uran0sH
uran0sH reviewed May 25, 2021
View reviewed changes
@kilosonc
feat: add method GetImplicitResourcesForUser
b630d18 
Signed-off-by: closetool <4closetool3@gmail.com>
@kilosonc kilosonc requested a review from uran0sH May 25, 2021 14:57
@hsluoyz
Copy link
Member

hsluoyz commented May 25, 2021

@lanmarti plz review. Although this is Go code, but if it looks OK, we will port it to Java.

lanmarti
lanmarti reviewed May 26, 2021
View reviewed changes
@hsluoyz hsluoyz merged commit fd2dd7f into apache:master May 26, 2021
@hsluoyz
Copy link
Member

hsluoyz commented May 26, 2021

@closetool plz add the new API to docs.

@hsluoyz hsluoyz mentioned this pull request May 26, 2021
Closed
@github-actions
Copy link

github-actions bot commented May 26, 2021

🎉 This PR is included in version 2.31.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@kilosonc kilosonc mentioned this pull request May 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sagilio sagilio Awaiting requested review from sagilio

2 more reviewers

@lanmarti lanmarti lanmarti approved these changes

@uran0sH uran0sH uran0sH approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support also resource grouping (g2) in GetImplicitPermissionsForUser()

4 participants

@kilosonc @hsluoyz @lanmarti @uran0sH