fix: bug of GetAllUsersByDomain#790
Merged
hsluoyz merged 1 commit intoapache:masterfrom May 16, 2021
kilosonc:updateEnhance
Merged
fix: bug of GetAllUsersByDomain#790hsluoyz merged 1 commit intoapache:masterfrom kilosonc:updateEnhance
hsluoyz merged 1 commit intoapache:masterfrom
kilosonc:updateEnhance
Conversation
Member
|
@wusphinx plz review. |
sagilio
reviewed
May 14, 2021
Contributor
There was a problem hiding this comment.
I have some question about this PR:
- Should we remove associated policy in
p?DeleteRoleForUserInDomainandDeleteRolesForUserInDomainwill not remove them. - Should this API return all roles and users? we only need to return
aliceandbobhere becauseadminis only a role according to the policy.
And I think adding GetAllRoles(domain...) or GetAllUsers(domain...) in RoleManager may better., not scanning all the p and g policies.
|
Great job! @closetool |
hsluoyz
requested changes
May 15, 2021
Signed-off-by: closetool <4closetool3@gmail.com>
hsluoyz
approved these changes
May 16, 2021
|
🎉 This PR is included in version 2.30.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: closetool 4closetool3@gmail.com
Fix: #789