Skip to content

feat: integrate default detector into Enforcer#1665

Merged
hsluoyz merged 3 commits intomasterfrom
copilot/integrate-default-detector-enforcer
Jan 8, 2026
Merged

feat: integrate default detector into Enforcer#1665
hsluoyz merged 3 commits intomasterfrom
copilot/integrate-default-detector-enforcer

Conversation

Copy link
Contributor

Copilot AI commented Jan 8, 2026

fix: #1664

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

…adPolicy

Co-authored-by: hsluoyz <3787410+hsluoyz@users.noreply.github.com>
Copilot AI changed the title [WIP] Integrate default detector into Casbin enforcer Integrate default detector into Enforcer with automatic cycle detection Jan 8, 2026
Copilot AI requested a review from hsluoyz January 8, 2026 14:39
@hsluoyz hsluoyz marked this pull request as ready for review January 8, 2026 14:40
@hsluoyz
Copy link
Member

hsluoyz commented Jan 8, 2026

@copilot fix:

4 errors and 2 warnings
[golangci](https://github.com/casbin/casbin/actions/runs/20820439101/job/59807693186#step:4:29)
issues found
[golangci: enforcer_test.go#L733](https://github.com/casbin/casbin/pull/1665/files#annotation_43856678388)
File is not `goimports`-ed (goimports)
[golangci: enforcer.go#L195](https://github.com/casbin/casbin/pull/1665/files#annotation_43856678401)
File is not `goimports`-ed (goimports)
[golangci: detector/default_detector.go#L73](https://github.com/casbin/casbin/pull/1665/files#annotation_43856678419)
File is not `goimports`-ed (goimports)

… detector/default_detector.go

Co-authored-by: hsluoyz <3787410+hsluoyz@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Jan 8, 2026

@copilot fix:

...

Fixed in commit 0a2cfe8. Ran goimports on all three files to remove trailing whitespace from blank lines.

@hsluoyz hsluoyz changed the title Integrate default detector into Enforcer with automatic cycle detection feat: integrate default detector into Enforcer Jan 8, 2026
@hsluoyz hsluoyz merged commit df4bccd into master Jan 8, 2026
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feature] integrate the default detector into Enforcer

3 participants