Merged
Conversation
|
|
- Created default_logger.go with DefaultLogger struct - Implemented all Logger interface methods (SetEventTypes, OnBeforeEvent, OnAfterEvent, SetLogCallback) - Added SetOutput method to support buffer/console output - Set StartTime in OnBeforeEvent and calculate Duration in OnAfterEvent - Filter events using LogEntry.IsActive based on SetEventTypes - Call user callback at end of OnAfterEvent if set - Use 2026 copyright header as requested Co-authored-by: hsluoyz <3787410+hsluoyz@users.noreply.github.com>
Use strings.TrimSuffix instead of direct string slicing to safely remove newline when adding error message Co-authored-by: hsluoyz <3787410+hsluoyz@users.noreply.github.com>
Benchmark ComparisonComparing base branch ( 🤖 This comment will be automatically updated with the latest benchmark results. |
Copilot
AI
changed the title
[WIP] Implement DefaultLogger following Logger interface
Implement DefaultLogger with event filtering and callback support
Jan 3, 2026
hsluoyz
added a commit
that referenced
this pull request
Jan 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a default implementation of the
Loggerinterface with configurable output, event-type filtering, duration tracking, and user callbacks.Implementation
DefaultLogger struct - Implements
Loggerinterface with:SetEventTypes()- Configures which event types to log viaLogEntry.IsActiveOnBeforeEvent()- RecordsStartTimeand setsIsActivebased on configured typesOnAfterEvent()- CalculatesDuration, writes logs if active, invokes user callbackSetLogCallback()- Registers user-provided callback executed after each eventSetOutput() - Routes log output to any
io.Writer(defaults toos.Stdout)Usage
Event filtering uses
LogEntry.IsActive- events not in the configured types are marked inactive and skipped. If no event types are configured, all events are active by default.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.