Skip to content

Conversation

@wesm
Copy link
Member

@wesm wesm commented Apr 24, 2017

Requires PARQUET-915 apache/parquet-cpp#311

@wesm
Copy link
Member Author

wesm commented Apr 24, 2017

I need to test some more cases:

  • time32[s] automatically casts to TIME_MILLIS
  • time64[ns] raises exception

@wesm
Copy link
Member Author

wesm commented Apr 25, 2017

OK, this is complete. I can rebase after PARQUET-915 is in

@xhochy
Copy link
Member

xhochy commented Apr 25, 2017

PARQUET-915 is in, please rebase ;)

Copy link
Member

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Merge on green build.

wesm added 4 commits April 25, 2017 09:39
…convert.cc

Change-Id: I8b88d398e08c921b7990b96ffffbc40f58ac6938
Change-Id: Ie32591cd8f4fd36f5572d535926fd0ab48b14271
Change-Id: I2c5c3ecacc50b6faa63e5241119cf0b6914ae864
Change-Id: Ib95a2c36482e8f95f2ca21c48c2f66c35e87d837
@wesm
Copy link
Member Author

wesm commented Apr 25, 2017

Rebased

@asfgit asfgit closed this in 68decb6 Apr 25, 2017
@wesm wesm deleted the ARROW-865 branch April 25, 2017 18:55
jeffknupp pushed a commit to jeffknupp/arrow that referenced this pull request Jun 3, 2017
…roundtrips

Requires PARQUET-915 apache/parquet-cpp#311

Author: Wes McKinney <wes.mckinney@twosigma.com>

Closes apache#595 from wesm/ARROW-865 and squashes the following commits:

db16940 [Wes McKinney] Add tests for auto-casted types, and unsupported nanosecond time
475fa3f [Wes McKinney] Fix test case
fad3934 [Wes McKinney] Update test case
da96a38 [Wes McKinney] Add failing Parquet test case. Enable same-type-size cases in pandas_convert.cc
pribor pushed a commit to GlobalWebIndex/arrow that referenced this pull request Oct 24, 2025
Fixes apacheGH-55.

### Rationale for this change
I fixed the linking error here:
apache#45114

### What changes are included in this PR?
Reenabling some disabled tests.

### Are these changes tested?
Yes, they are tests.

### Are there any user-facing changes?
No.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants