-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-15644: [C++][Gandiva] Implement Find_In_Set Function #12391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
ViniciusSouzaRoque
wants to merge
8
commits into
apache:master
from
s1mbi0se:feature/add-find-in-set-function
Closed
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
50fd0af
First implementation function Find in Set
b4c6692
Added UTF8 Support
c760975
Change output test name
443e9b0
Remove invalid return to empty strings
a0ae3e4
Skip utf8 length check
67e2182
Fix return to empty strings
92c8bd6
Add requested tests
3dcca02
Empty commit to run CI
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3034,4 +3034,45 @@ int32_t instr_utf8(const char* string, int32_t string_len, const char* substring | |
| } | ||
| return 0; | ||
| } | ||
|
|
||
| FORCE_INLINE | ||
| int32_t find_in_set_utf8_utf8(int64_t context, const char* to_find, int32_t to_find_len, | ||
| const char* string_list, int32_t string_list_len) { | ||
| // Return 0 if to search entry have commas | ||
| if (is_substr_utf8_utf8(to_find, to_find_len, reinterpret_cast<const char*>(","), 1)) { | ||
| return 0; | ||
| } | ||
|
|
||
| int32_t cur_pos_in_array = 0; | ||
| int32_t cur_length = 0; | ||
| bool matching = true; | ||
|
|
||
| for (int i = 0; i < string_list_len; i++) { | ||
| if (string_list[i] == ',') { | ||
| cur_pos_in_array++; | ||
| if (matching && cur_length == to_find_len) { | ||
| return cur_pos_in_array; | ||
| } else { | ||
| matching = true; | ||
| cur_length = 0; | ||
| } | ||
| } else { | ||
| if (cur_length + 1 <= string_list_len) { | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why this condition? In which situation is it false? |
||
| if (!matching || (memcmp(string_list + i, to_find + cur_length, 1))) { | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why call |
||
| matching = false; | ||
| } | ||
| } else { | ||
| matching = false; | ||
| } | ||
| cur_length++; | ||
| } | ||
| } | ||
|
|
||
| if (matching && cur_length == to_find_len) { | ||
| cur_pos_in_array++; | ||
| return cur_pos_in_array; | ||
| } else { | ||
| return 0; | ||
| } | ||
| } | ||
| } // extern "C" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you are looking for a single unicode codepoint below 128, you can probably do this faster using
memchr.