[ARROW-RS-7820][Variant] Add tests for large variant lists #7876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@alamb Please help review this when you're free, thanks. |
klion26
force-pushed
the
7820-test-for-large-variant-list
branch
from
e35d448 to
c65058c
Compare
klion26
commented
Jul 7, 2025
alamb
reviewed
Jul 7, 2025
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @klion26 -- this looks great
I left a comment about checking the list offsets. Let us know what you think
cc @friendlymatthew and @scovich
Member
Author
|
@alamb, thanks for the review. I've addressed the comment. Please take another look when you're free. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Add tests for large variant list.
VariantLists #7820 .Rationale for this change
Add tests for larget vairant lists
What changes are included in this PR?
This PR adds three tests for large variant lists.
all the tests will verify the
is_large,offset_sizeand the content of the list.Are these changes tested?
Yes
Are there any user-facing changes?
Non