Fix List Comprehension shift/reduce grammar issue. #1628
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the List Comprehension shift/reduce grammar issue by creating a new keyword, FROM, to replace IN. Updated the sql and regression tests to align with the changes.
jrgemignani
requested review from
MuhammadTahaNaveed,
Zainab-Saad,
dehowef,
muhammadshoaib and
rafsun42
Member
|
@jrgemignani Shift/reduce conflict with list comprehension was resolved by PR #1719. I am going ahead with closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the List Comprehension shift/reduce grammar issue by creating a new keyword, FROM, to replace IN.
Updated the sql and regression tests to align with the changes.
This is just a proof of concept PR for review. It shows that the shift/reduce warning can be removed with a keyword change.
Please do not merge this PR unless fully discussed and approved.