Skip to content

Conversation

@DomGarguilo
Copy link
Member

Fixes #6035
This PR adds new options to the listtablets command and also removed one from the getavailability command.

Added row range filtering to listtablets matching what getavailability already supports:

  -b,--begin-row <arg>            begin row (inclusive)
  -be,--begin-exclusive           make start row exclusive (by default it's inclusive)
  -e,--end-row <end-row>          end row (inclusive)

The -ee/--end-exclusive option was removed from getavailability since it was not being used anyways. Ultimately both listtablets and getavailability call this portion of the code which just sets end exclusive to true:

@Override
public Options overlapping(Text startRow, boolean startInclusive, Text endRow) {
var metaStartRow =
TabletsSection.encodeRow(tableId, startRow == null ? new Text("") : startRow);
var metaEndRow = TabletsSection.encodeRow(tableId, null);
this.range =
new Range(metaStartRow, startRow == null ? true : startInclusive, metaEndRow, true);
this.endRow = endRow;
return this;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add RowRange filters to listtablets command

1 participant