Fix SINDI index returning no results after deserialization#1623
Closed
Fix SINDI index returning no results after deserialization#1623
Conversation
Co-authored-by: wxyucs <12595343+wxyucs@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix deserialization issue for SINDI index
Fix SINDI index returning no results after deserialization
Mar 4, 2026
Collaborator
|
same as #1621 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SparseTermDataCell::total_count_is never persisted duringSerializenor restored duringDeserialize. SinceInsertHeapByDistsuses it as the loop bound, a deserialized index processes zero candidates and returns empty results — regardless of index contents.Changes
src/datacell/sparse_term_datacell.cpp: Reconstructtotal_count_inDeserializeby scanning the loadedterm_ids_and computingmax(inner_id) + 1. Backward compatible — no format change required, existing serialized files work correctly.src/algorithm/sindi/sindi_test.cpp: Assertanother_result->GetDim() == result->GetDim()after deserializing, so this regression is caught by unit tests.Root cause
Original prompt
This section details on the original issue you should resolve
<issue_title>No results can be retrieved after deserializing from the file for the SINDI index</issue_title>
<issue_description>Describe the bug
No results can be retrieved after deserializing from the file for the sindi index. However, for the same data, if you query it immediately after it is constructed, you can obtain the results.
To Reproduce
deserialize from index
same data