fix(acp): rename setSessionModel to unstable_setSessionModel #9940
+52
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ACP SDK v0.12.0 renamed this method, causing 'Method not found' errors when JetBrains/IntelliJ clients called session/set_model. SDK commit that renamed the method: agentclientprotocol/typescript-sdk@7072d3f Same fix applied by Qwen Code: QwenLM/qwen-code#1521 Added unit test to catch future SDK interface changes at compile time.
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #9941
setSessionModel→unstable_setSessionModelto match ACP SDK v0.12.0+ interfaceRoot Cause
The ACP TypeScript SDK v0.12.0 renamed this method in commit 7072d3f. The SDK's router checks
if (!agent.unstable_setSessionModel)and throws "Method not found" when missing.References