Update docker build command for syncserver#4562
Open
CYPHER0041 wants to merge 3 commits intoankitects:mainfrom
Open
Update docker build command for syncserver#4562CYPHER0041 wants to merge 3 commits intoankitects:mainfrom
CYPHER0041 wants to merge 3 commits intoankitects:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The command for building the image does not include the
--platformflag which prevents the image from running across all architectures. For example, if I build the image on an ARM system and then try running on x86, it won’t work.This issue can be fixed by using
docker buildxand adding the flag to include all of the platforms. I have tested this by building the image with thelinux/arm64andlinux/amd64platform flags on an ARM system and then running a container with that image on an x86 system.This would be useful in scenarios where the syncserver runs on devices that cannot do builds.
The correct command would be
Reference: https://docs.docker.com/build/building/multi-platform/