Skip to content

Conversation

crisbeto
Copy link
Member

We had a few tests in the chips that were only passing with NoopAnimationsModule. These changes rework the tests and drop the dependency.

We had a few tests in the chips that were only passing with `NoopAnimationsModule`. These changes rework the tests and drop the dependency.
@crisbeto crisbeto added the target: major This PR is targeted for the next major release label Aug 27, 2025
@crisbeto crisbeto marked this pull request as ready for review August 27, 2025 12:54
@crisbeto crisbeto requested a review from a team as a code owner August 27, 2025 12:54
@crisbeto crisbeto requested review from mmalerba and andrewseguin and removed request for a team August 27, 2025 12:54
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto removed the request for review from mmalerba August 27, 2025 21:15
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Aug 27, 2025
@crisbeto crisbeto merged commit 4de4b29 into angular:main Aug 27, 2025
35 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: material/chips target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants