Skip to content

Revert "fix(cdk/testing): simulate focusin/focusout events"#23794

Merged
andrewseguin merged 1 commit intoangular:masterfrom
andrewseguin:revert-focus
Oct 20, 2021
Merged

Revert "fix(cdk/testing): simulate focusin/focusout events"#23794
andrewseguin merged 1 commit intoangular:masterfrom
andrewseguin:revert-focus

Conversation

@andrewseguin
Copy link
Copy Markdown
Contributor

This reverts commit ef7d9e0.

I misread the test results and it looks like there was about 5 tests that ended up failing because of this. Need to do more investigation of why these failed.

@andrewseguin andrewseguin added the target: patch This PR is targeted for the next patch release label Oct 20, 2021
@andrewseguin andrewseguin requested a review from crisbeto October 20, 2021 12:07
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 20, 2021
Copy link
Copy Markdown
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewseguin andrewseguin added the action: merge The PR is ready for merge by the caretaker label Oct 20, 2021
@andrewseguin andrewseguin merged commit 5f72dbc into angular:master Oct 20, 2021
andrewseguin added a commit that referenced this pull request Oct 20, 2021
andrewseguin added a commit that referenced this pull request Oct 20, 2021
forsti0506 pushed a commit to forsti0506/components that referenced this pull request Oct 22, 2021
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants