Skip to content

fix(material/tabs): incorrect ripple color when CSS variables are used for theme#23686

Merged
andrewseguin merged 1 commit intoangular:masterfrom
crisbeto:23681/tabs-ripple-theming
Oct 19, 2021
Merged

fix(material/tabs): incorrect ripple color when CSS variables are used for theme#23686
andrewseguin merged 1 commit intoangular:masterfrom
crisbeto:23681/tabs-ripple-theming

Conversation

@crisbeto
Copy link
Copy Markdown
Member

@crisbeto crisbeto commented Oct 5, 2021

Fixes that a tab group with a background color has a solid ripple color when the theme is based on CSS variables.

Fixes #23681.

…d for theme

Fixes that a tab group with a background color has a solid ripple color when the theme is based on CSS variables.

Fixes angular#23681.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Oct 5, 2021
@crisbeto crisbeto requested a review from andrewseguin October 5, 2021 13:21
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 5, 2021
@andrewseguin andrewseguin added the action: merge The PR is ready for merge by the caretaker label Oct 18, 2021
@andrewseguin andrewseguin merged commit 9109c3c into angular:master Oct 19, 2021
andrewseguin pushed a commit that referenced this pull request Oct 19, 2021
…d for theme (#23686)

Fixes that a tab group with a background color has a solid ripple color when the theme is based on CSS variables.

Fixes #23681.

(cherry picked from commit 9109c3c)
andrewseguin pushed a commit that referenced this pull request Oct 19, 2021
…d for theme (#23686)

Fixes that a tab group with a background color has a solid ripple color when the theme is based on CSS variables.

Fixes #23681.

(cherry picked from commit 9109c3c)
forsti0506 pushed a commit to forsti0506/components that referenced this pull request Oct 22, 2021
…d for theme (angular#23686)

Fixes that a tab group with a background color has a solid ripple color when the theme is based on CSS variables.

Fixes angular#23681.
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(mat-tab-group): ripple doesn't support custom theme with CSS variables

2 participants