fix(material-experimental/mdc-menu): fix bold font when using 2014 typography#23614
fix(material-experimental/mdc-menu): fix bold font when using 2014 typography#23614mmalerba wants to merge 1 commit intoangular:masterfrom
Conversation
mmalerba
added
P2
google-cla
bot
added
the
cla: yes
| // When the 2014 typography config is mapped to the 2018 config, the font-weight that winds up | ||
| // getting used for menu items looks slightly off. In this case we override it to a value that | ||
| // looks better. | ||
| @if (typography.private-typography-is-2014-config($config-or-theme)) { |
There was a problem hiding this comment.
Should we fix this at a higher level? I think that select and autocomplete (and maybe list?) use the same set of mixins.
There was a problem hiding this comment.
Yeah that's a good point. Let's merge this PR because its smaller in scope and will unblock me for the menu migrations I'm working on, but as a follow-up I'll try to address this more holistically
There was a problem hiding this comment.
So @andrewseguin made the opposite hack for table when he was working on that migration. There the font wasn't bold enough. Looking into it more I found that if we just ignore how the levels are named, they actually map better visually if we just swap them, so that's what I've done in #23618 which allows us to remove both this hack and Andrew's 🎉
mmalerba
added
blocked
|
Closing in favor of #23618 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
3 participants
No description provided.