fix(material/list): fix action-list focus state for high contrast fir…#23584
Merged
wagnermaciel merged 1 commit intoangular:masterfrom Sep 16, 2021
Merged
fix(material/list): fix action-list focus state for high contrast fir…#23584wagnermaciel merged 1 commit intoangular:masterfrom
wagnermaciel merged 1 commit intoangular:masterfrom
Conversation
…efox Fixes the focus state on the action-list for firefox in high-contrast mode. In firefox, the outline only renders on the top, right and left – not the bottom. This fixes the bottom of the outline being cut-off by setting the z-index of the focused list item to 1. fixes angular#23583
zarend
added
Accessibility
google-cla
bot
added
the
cla: yes
jelbourn
added
action: merge
devversion
approved these changes
Sep 15, 2021
wagnermaciel
pushed a commit
that referenced
this pull request
Sep 16, 2021
…efox (#23584) Fixes the focus state on the action-list for firefox in high-contrast mode. In firefox, the outline only renders on the top, right and left – not the bottom. This fixes the bottom of the outline being cut-off by setting the z-index of the focused list item to 1. fixes #23583 (cherry picked from commit ef4fc56)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…efox
From the commit message
Fixes the focus state on the action-list for firefox in high-contrast
mode. In firefox, the outline only renders on the top, right and left –
not the bottom. This fixes the bottom of the outline being cut-off by
setting the z-index of the focused list item to 1.
fixes #23583
Other things I've tried
Also tried using margin but that turned out to be harder than this because we would also have to update the background of the list. This seems to only happen with buttons inside the list, but works fine with divs. I know that outline works differently between Firefox and Chrome, but I couldn't find a specific bug report for this situation.
I also considered ditching outline and using a box-shadow instead, but then the action-list's focus state would match our nav-list and other lists.